Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composer bin-dir $PATH settings #448

Merged
merged 6 commits into from Nov 23, 2020
Merged

Fix composer bin-dir $PATH settings #448

merged 6 commits into from Nov 23, 2020

Conversation

dzuelke
Copy link
Contributor

@dzuelke dzuelke commented Nov 22, 2020

  • at runtime, it's a relative path (minor)
  • at build time, it's never been exported correctly (because it added /app/vendor/bin, not /tmp/build…/vendor/bin), but now the export also causes an error message (without affecting build success)

@dzuelke dzuelke requested a review from a team as a code owner November 22, 2020 23:10
this has always been broken, just nobody noticed... it exported /app/vendor/bin etc initially, and since v184, it was broken in a different way
@dzuelke dzuelke force-pushed the develop branch 2 times, most recently from 81cec7a to f16eaf6 Compare November 23, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants