Skip to content

Commit

Permalink
Update AWS_DEFAULT_REGION to match the current S3 region (#1461)
Browse files Browse the repository at this point in the history
The AWS CLI requires that the `AWS_DEFAULT_REGION` env var
be set in order for authentication to work.

Previously `AWS_DEFAULT_REGION` was set to `us-west-2`, however,
this is different from the region our S3 buckets are in (`us-east-1`).

Whilst this doesn't affect the command we run at all, it caused confusion
recently as to what region the Python bucket was in, so for clarity the
default value has now been changed to match the region of the S3 bucket
`heroku-buildpack-python`.
  • Loading branch information
edmorley committed Jul 10, 2023
1 parent 3293b4f commit 2b630dd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build_python_runtime.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ permissions:
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_DEFAULT_REGION: "us-west-2"
AWS_DEFAULT_REGION: "us-east-1"
S3_BUCKET: "heroku-buildpack-python"

# Unfortunately these jobs cannot be easily written as a matrix since `matrix.exclude` does not
Expand Down

0 comments on commit 2b630dd

Please sign in to comment.