Remove support for Heroku-18 #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Heroku-18 stack has reached end-of-life, and as such build using it are no longer supported by the Heroku build system: https://devcenter.heroku.com/changelog-items/2583 This fixes the integration tests failing in CI for the Heroku-18 stack, due to the build system now (as expected) rejecting the jobs, eg: https://github.com/heroku/heroku-buildpack-python/actions/runs/4852163562/jobs/8646809603?pr=1448#step:5:165 The Heroku-18 stack was the last to have Python binaries available for Python 2.7, 3.5 and 3.5, so the EOL conditionals and testcases for those versions have now been removed. Any non-Heroku consumers of this buildpack that wish to continue using the Heroku-18 stack should pin to the previous version of this buildpack. GUS-W-10446293.
This was referenced May 2, 2023
Malax
approved these changes
May 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Heroku-18 stack has reached end-of-life, and as such build using it are no longer supported by the Heroku build system:
https://devcenter.heroku.com/changelog-items/2583
This fixes the integration tests failing in CI for the Heroku-18 stack, due to the build system now (as expected) rejecting the jobs, eg:
https://github.com/heroku/heroku-buildpack-python/actions/runs/4852163562/jobs/8646809603?pr=1448#step:5:165
The Heroku-18 stack was the last to have Python binaries available for Python 2.7, 3.5 and 3.5, so the EOL conditionals and testcases for those versions have now been removed.
Any non-Heroku consumers of this buildpack that wish to continue using the Heroku-18 stack should pin to the previous version of this buildpack.
Prior to releasing a new version of this buildpack containing this change, I will make sure the
heroku/buildpacks:18CNB builder image is pinned to the last CNB registry release.GUS-W-10446293.