Add buildpack support for Heroku-24 #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
edmorley
force-pushed
the
heroku-24-binaries
branch
from
d48e8c4
to
d4b40b2
Compare
edmorley
force-pushed
the
heroku-24-buildpack-support
branch
3 times, most recently
from
c29625b
to
109db51
Compare
Following on from #1574 (which added support for building and releasing Python binaries for Heroku-24), this adds support for the new stack to the buildpack itself. Heroku-24's base images are published as both `amd64` and `arm64` variants (primarily for CNB multi-arch support), so the buildpack now checks the architecture where necessary to ensure it continues to operate should it be run against the `arm64` image outside of Heroku. (However, when run on Heroku, this buildpack is still only ever run on `amd64`.) GUS-W-14667590.
edmorley
force-pushed
the
heroku-24-buildpack-support
branch
from
109db51
to
79e005d
Compare
dzuelke
approved these changes
Apr 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #1574 (which added support for building and releasing Python binaries for Heroku-24), this adds support for the new stack to the buildpack itself.
Heroku-24's base images are published as both
amd64andarm64variants (primarily for CNB multi-arch support), so the buildpack now checks the architecture where necessary to ensure it continues to operate should it be run against thearm64image outside of Heroku (for example, on an ARM M1/M2/M3 CPU MacBook). However, when run on Heroku, this buildpack is still only ever run onamd64.GUS-W-14667590.