make node.js binary available to the Python lang pack #24

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

Cheerfully inspired by how the Ruby buildpack does it (and uses the same
binary, only stored in an Audish bucket so it won't get swapped under
our feet).

See also:
heroku/heroku-buildpack-ruby@c5430bc

@yaniv-aknin yaniv-aknin make node.js binary available to the Python lang pack
Cheerfully inspired by how the Ruby buildpack does it (and uses the same
binary, only stored in an Audish bucket so it won't get swapped under
our feet).

See also:
heroku/heroku-buildpack-ruby@c5430bc
e4779ee

There's a workaround for PyExecJS 1.0.0 here that apparently isn't needed anymore. Just FYI if you want to leave it in or not.

Contributor

I don't think I'm going to be able to merge this. Ruby's node bundling is a tad controversial, but since node is technically a dependency of Rails (because of the coffeescript support), it had to be included.

I'm curious to know what your use case is, though.

CoffeeScript support :)

Ruby vendors Node if "execjs" is in Gemfile.
I vendor Node to Python if "pyexecjs" is in requirements.txt. Same usecase.

This way I can share validation code client/server side, and execute coffee
server side.

On Friday, January 13, 2012, Kenneth Reitz <
reply@reply.github.com>
wrote:

I don't think I'm going to be able to merge this. Ruby's node bundling is
a controversial, but since node is technically a dependency of Rails
(because of the coffeescript support), it had to be included.

I'm curious to know what your use case is, though.


Reply to this email directly or view it on GitHub:

#24 (comment)

Contributor

I'll consider adding this if that module sees real traction/usage. In the meantime, running this as your own buildpack is definitely best. That's what custom buildpacks are for :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment