Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect manifest-(fingerprint).json instead of manifest.yml for rails4 #72

Closed
brettgoulder opened this issue Mar 11, 2013 · 7 comments
Closed

Comments

@brettgoulder
Copy link

manifest.yml is not created in rails4 anymore, it's manifest-(fingerprint).json

https://github.com/heroku/heroku-buildpack-ruby/blob/master/lib/language_pack/rails4.rb#L40

@schneems
Copy link
Contributor

(╯°□°)╯︵ ┻━┻)

@hone
Copy link
Member

hone commented Mar 11, 2013

oops! how is the fingerprint generated?

@brettgoulder
Copy link
Author

@catsby
Copy link
Contributor

catsby commented Mar 11, 2013

So on https://github.com/heroku/heroku-buildpack-ruby/blob/master/lib/language_pack/rails4.rb#L40-L57, change:

if File.exists?("public/assets/manifest.yml")
...
else

to

unless Dir.glob('public/assets/manifest-*.json').empty?
...
else

If you're like me and don't care for unless [...] else l, then just swap the code blocks. That work?

@hone
Copy link
Member

hone commented Mar 11, 2013

I think that looks right.

@catsby
Copy link
Contributor

catsby commented Mar 11, 2013

@brettgoulder suggested if Dir.glob('public/assets/manifest-*.json').any? as opposed to the unless..else.

@hone
Copy link
Member

hone commented May 20, 2013

Fixed by #74 .

@hone hone closed this as completed May 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants