Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing the "Removing of Gemfile.lock when "windows platform" is detected in it" hack #91

Closed
urkle opened this issue Apr 29, 2013 · 2 comments
Closed

removing the "Removing of Gemfile.lock when "windows platform" is detected in it" hack #91

urkle opened this issue Apr 29, 2013 · 2 comments

Comments

@urkle
Copy link

urkle commented Apr 29, 2013

According to the bundler issue rubygems/bundler#635 this hack is no longer needed as current bundler release (1.1.2 at least) handle this correctly and do not try to install windows gems on unix boxes.
@hone
Copy link
Member

hone commented Jun 18, 2013

Multiplatform support is definitely not fully working in bundler. Last time I looked into this, there were still some issues. Can you provide a windows app I can use to do some further testing. @wycats suggested that in windows I can just run without --deployment for the windows case.

Billiam added a commit to Billiam/heroku-buildpack-ruby that referenced this issue Aug 16, 2013
@Billiam
Removed windows gemfile.lock unlinking
4facc36 
Resolves heroku#91
@schneems
Copy link
Contributor

Would love to get some more windows parity. Is it worth putting this into an upcoming quarter? Maybe we can fund this feature in bundler?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hone @schneems @urkle