[fix #182] Show Warning In-line for Windows Gems #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
added a commit
that referenced
this pull request
Nov 20, 2013
When deploying a Gemfile.lock that has been generated via windows, we must remove the file which can cause bundler to not be able to resolve. When bundler does not resolve, the end user never sees the windows warning message due to the resolver never finishing (since warnings are saved until the end of the output). This change allows warnings to be emitted inline and changes the default behavior of the windows warning to display before the `bundle install` is run, thus mitigating this problem. Even when the `bundle install` fails the warnings are not displayed since the process `exits` rather than continues to print out the warnings. Here is a link to the devcenter article I wrote for this PR https://devcenter.heroku.com/articles/bundler-windows-gemfile
|
Let's roll up all the warnings at the end. |
When deploying a Gemfile.lock that has been generated via windows, we must remove the file which can cause bundler to not be able to resolve. When bundler does not resolve, the end user never sees the windows warning message due to the resolver never finishing (since warnings are saved until the end of the output). This change allows warnings to be emitted inline and changes the default behavior of the windows warning to display before the `bundle install` is run, thus mitigating this problem. Even when the `bundle install` fails the warnings are not displayed since the process `exits` rather than continues to print out the warnings. Here is a link to the devcenter article I wrote for this PR https://devcenter.heroku.com/articles/bundler-windows-gemfile
|
Not sure what's going on here, all builds pass until I added the changelog 😦 |
|
Merging in, if master continues to fail i'll revert |
schneems
added a commit
that referenced
this pull request
Dec 10, 2013
[fix #182] Show Warning In-line for Windows Gems
schneems
added a commit
to hone/heroku-buildpack-ruby
that referenced
this pull request
Dec 16, 2013
When deploying a Gemfile.lock that has been generated via windows, we must remove the file which can cause bundler to not be able to resolve. When bundler does not resolve, the end user never sees the windows warning message due to the resolver never finishing (since warnings are saved until the end of the output). This change allows warnings to be emitted inline and changes the default behavior of the windows warning to display before the `bundle install` is run, thus mitigating this problem. Even when the `bundle install` fails the warnings are not displayed since the process `exits` rather than continues to print out the warnings. Here is a link to the devcenter article I wrote for this PR https://devcenter.heroku.com/articles/bundler-windows-gemfile
schneems
added a commit
that referenced
this pull request
Dec 30, 2013
When deploying a Gemfile.lock that has been generated via windows, we must remove the file which can cause bundler to not be able to resolve. When bundler does not resolve, the end user never sees the windows warning message due to the resolver never finishing (since warnings are saved until the end of the output). This change allows warnings to be emitted inline and changes the default behavior of the windows warning to display before the `bundle install` is run, thus mitigating this problem. Even when the `bundle install` fails the warnings are not displayed since the process `exits` rather than continues to print out the warnings. Here is a link to the devcenter article I wrote for this PR https://devcenter.heroku.com/articles/bundler-windows-gemfile
gbenedict
pushed a commit
to RedFunnel/heroku-buildpack-ruby
that referenced
this pull request
Jan 9, 2014
When deploying a Gemfile.lock that has been generated via windows, we must remove the file which can cause bundler to not be able to resolve. When bundler does not resolve, the end user never sees the windows warning message due to the resolver never finishing (since warnings are saved until the end of the output). This change allows warnings to be emitted inline and changes the default behavior of the windows warning to display before the `bundle install` is run, thus mitigating this problem. Even when the `bundle install` fails the warnings are not displayed since the process `exits` rather than continues to print out the warnings. Here is a link to the devcenter article I wrote for this PR https://devcenter.heroku.com/articles/bundler-windows-gemfile
squeedee
referenced
this pull request
in cloudfoundry/ruby-buildpack
Apr 10, 2014
When deploying a Gemfile.lock that has been generated via windows, we must remove the file which can cause bundler to not be able to resolve. When bundler does not resolve, the end user never sees the windows warning message due to the resolver never finishing (since warnings are saved until the end of the output). This change allows warnings to be emitted inline and changes the default behavior of the windows warning to display before the `bundle install` is run, thus mitigating this problem. Even when the `bundle install` fails the warnings are not displayed since the process `exits` rather than continues to print out the warnings. Here is a link to the devcenter article I wrote for this PR https://devcenter.heroku.com/articles/bundler-windows-gemfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying a Gemfile.lock that has been generated via windows, we must remove the file which can cause bundler to not be able to resolve.
When bundler does not resolve, the end user never sees the windows warning message due to the resolver never finishing (since warnings are saved until the end of the output).
This change allows warnings to be emitted inline and changes the default behavior of the windows warning to display before the
bundle installis run, thus mitigating this problem.Even when the
bundle installfails the warnings are not displayed since the processexitsrather than continues to print out the warnings.Here is a link to the devcenter article I wrote for this PR https://devcenter.heroku.com/articles/bundler-windows-gemfile