Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automatic heap settings for IX dyno #428

Merged
merged 1 commit into from Oct 28, 2015
Merged

Added automatic heap settings for IX dyno #428

merged 1 commit into from Oct 28, 2015

Conversation

jkutner
Copy link
Contributor

@jkutner jkutner commented Oct 28, 2015

No description provided.

@@ -244,7 +247,7 @@ def default_jruby_opts
# default JAVA_TOOL_OPTIONS
# return [String] string of JAVA_TOOL_OPTIONS
def default_java_tool_options
"-Xmx${JVM_MAX_HEAP:-\"384\"}m -Djava.rmi.server.useCodebaseOnly=true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need this any more? This change seems unrelated to the PR.

@hone
Copy link
Member

hone commented Oct 28, 2015

Couldn't repro this failure locally. Rerunning the build. Suspect that even though we hardcoded engines.node to 0.10.3 that it installed 4.1.2. O_o /cc @hunterloftis

@hone
Copy link
Member

hone commented Oct 28, 2015

Ugh, n/m sharpstone/node_multi@b2e1971 broke the test. I'll patch this.

hone added a commit that referenced this pull request Oct 28, 2015
Added automatic heap settings for IX dyno
@hone hone merged commit 8e037b6 into master Oct 28, 2015
@hone hone deleted the jruby-ix branch October 28, 2015 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants