Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schneems/ruby version mismatch #514

Merged
merged 2 commits into from Dec 12, 2016
Merged

Schneems/ruby version mismatch #514

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f041dc9
Error formatting
schneems Dec 9, 2016
1f624dd
Emit helpful url on Ruby version mismatch
schneems Dec 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 12 additions & 4 deletions lib/language_pack/ruby.rb
View file
Open in desktop
Expand Up @@ -652,12 +652,20 @@ def build_bundler
error_message = "Failed to install gems via Bundler."
puts "Bundler Output: #{bundler_output}"
if bundler_output.match(/An error occurred while installing sqlite3/)
error_message += <<ERROR
error_message += <<-ERROR


Detected sqlite3 gem which is not supported on Heroku.
Detected sqlite3 gem which is not supported on Heroku:
https://devcenter.heroku.com/articles/sqlite3
ERROR
ERROR
end

if bundler_output.match(/but your Gemfile specified/)
error_message += <<-ERROR

Detected a mismatch between your Ruby version installed and
Ruby version specified in Gemfile or Gemfile.lock:
https://devcenter.heroku.com/articles/ruby-versions#your-ruby-version-is-x-but-your-gemfile-specified-y
ERROR
end

error error_message
Expand Down