Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix #57. Clean URLs clean even if there's a directory #62

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Fix #57. Clean URLs clean even if there's a directory #62

merged 1 commit into from
Mar 16, 2017

Conversation

hone
Copy link
Member

@hone hone commented Mar 16, 2017 •
edited
Loading

This fixes #57.

Having the folder structure:

join/
join/developer.html
join.html

combined with clean_urls when /join is hit will return join.html.

@hone
Copy link
Member Author

hone commented Mar 16, 2017

@searls can you confirm this fixes your problem?

@hone
Fix #57. Clean URLs clean even if there's a directory
df1001f 
Having join/developer.html, join.html, and clean_urls set now allows
join.html to be resolved when hitting /join/
@searls
Copy link

searls commented Mar 16, 2017

👍

http://testdouble.com/join <-- works
http://testdouble.com/join/ <-- 403 forbidden
http://testdouble.com/join/developer <-- works

@hone hone merged commit d03c271 into master Mar 16, 2017
@hone hone deleted the clean_urls_conflict branch March 16, 2017 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean URLs won't clean if there's a directory
2 participants
@hone @searls