This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Allow FORCE_HTTPS to be specified as an environment variable #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/config/lib/nginx_config.rb
Outdated
| @@ -44,6 +44,7 @@ def initialize(json_file) | |||
|
|
|||
| json["clean_urls"] ||= DEFAULT[:clean_urls] | |||
| json["https_only"] ||= DEFAULT[:https_only] | |||
| json["https_only"] ||= ENV["FORCE_HTTPS"].present? && ENV["FORCE_HTTPS"] === "true" | |||
There was a problem hiding this comment.
Do we want to fall back to the default?
There was a problem hiding this comment.
The default is still applied in the line above.
|
@hone when we can expect merge of this :)? |
|
Hi This buildpack is now deprecated and we are recommending people move the more actively maintained heroku-buildpack-nginx. For migration advice see here. As such, I'm closing this PR out since we won't be making further changes to this buildpack. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to specify
FORCE_HTTPSas a config environment variable similar to what you could do in this buildpack https://github.com/tonycoco/heroku-buildpack-ember-cli/blob/e4aed2b98bde656c6921120fb87ec53040195590/config/nginx.conf.erb#L60.