Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul heroku-deploy-standalone #232

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

Malax
Copy link
Member

@Malax Malax commented Nov 7, 2023

This PR overhauls heroku-deploy-standalone. Main objectives were to:

  • Improve UX.
  • Provide in-line help in failure scenarios.
  • Align feature set with build tool Heroku deploy plugins (such as heroku-maven-plugin).
  • Improve security by automatically using the latest webapp-runner instead of a fixed version.
  • Add a basic suite of integration tests.

This is just the first PR in a sequence for heroku-deploy-standalone improvements and eventual sunset of heroku-maven-plugin.

PR roadmap:

  • Windows integration tests.
  • Extended integration tests for more advanced use-cases.
  • Improved README.
  • Removal of heroku-deploy, heroku-maven-plugin and code that is no longer necessary after removal of the former modules.
  • Support for Heroku-Deploy-Type header.
  • Maybe: Caching of Rust dependencies in CI.

Review notes:

Code changes to the CLI are in commit 2e4df22. Integration tests in 36b7a35. Both commits can be reviewed independently.

Ref: GUS-W-14462146, GUS-W-14462149

@Malax Malax force-pushed the malax/heroku-deploy-standalone-4.0.0 branch 13 times, most recently from d3bc2e8 to a4ec9d9 Compare November 13, 2023 14:53
@Malax Malax force-pushed the malax/heroku-deploy-standalone-4.0.0 branch from a4ec9d9 to 36b7a35 Compare November 13, 2023 15:58
@Malax Malax marked this pull request as ready for review November 13, 2023 16:10
@Malax Malax requested a review from a team as a code owner November 13, 2023 16:10
@Malax Malax merged commit 6f429a2 into main Nov 14, 2023
4 checks passed
@Malax Malax deleted the malax/heroku-deploy-standalone-4.0.0 branch November 14, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants