Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make main file optional #258

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Make main file optional #258

merged 2 commits into from
Dec 5, 2023

Conversation

Malax
Copy link
Member

@Malax Malax commented Dec 4, 2023 •
edited

Changelog

  • Specifying A main file is no longer required. This allows easy deployment in cases where application startup is managed by a shell script, such as when using sbt-native-packager.

Ref: GUS-W-14598308

@Malax Malax marked this pull request as ready for review December 4, 2023 10:32
@Malax Malax requested a review from a team as a code owner December 4, 2023 10:32
edmorley
edmorley approved these changes Dec 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/main/java/com/heroku/deployer/Main.java Show resolved Hide resolved
@Malax Malax merged commit 8cbf858 into main Dec 5, 2023
4 of 5 checks passed
@Malax Malax deleted the malax/optional-main-file branch December 5, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Malax @edmorley