Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the missing command option #79

Closed
wants to merge 2 commits into from
Closed

Conversation

rhettc
Copy link

@rhettc rhettc commented Apr 16, 2014

Added support to supply SQL when invoking this command.

Also includes the prompt feature mentioned in #71. I figured that as long as this command is stepping on the original implementation, it might as well have better feature parity.

…tation. Also adds support for rewriting the prompt to display the app name, like the native implementation had done.
@msakrejda
Copy link
Contributor

Thanks for the pull request, but I think continuing separate implemenations of pg:psql across the toolbelt and this plugin seems like a really bad idea. I think we need to resolve that issue before adding any more functionality here, probably by adding --set hooks to the toolbelt that this plugin can shim into, and leaving the main pg:psql command in the toolbelt.

@rhettc
Copy link
Author

rhettc commented Apr 18, 2014

Yeah - I think that's a good plan. However, currently, users that are installing this plugin are losing functionality because even thought the documentation was copied from the original, it doesn't implement the features advertised. It's a frustrating user experience, and after the second time I found myself scratching my head in a matter of weeks,I decided to offer this fix. Respectfully, I don't see this as adding a new feature, just making the add-in comply with the requirements.

@will
Copy link
Contributor

will commented Oct 24, 2014

The pg-extras pqsl no longer shadows the toolbelt's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants