Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

add warning if follower is behind #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mehtaphysical
Copy link
Contributor

add a warning to pg:unfollow if the follower is behind

@codecov-io
Copy link

Codecov Report

Merging #187 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #187      +/-   ##
=========================================
+ Coverage   95.39%   95.4%   +0.01%     
=========================================
  Files          54      54              
  Lines        1347    1350       +3     
=========================================
+ Hits         1285    1288       +3     
  Misses         62      62
Impacted Files Coverage Δ
commands/unfollow.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b5ffd4...2a3a8f0. Read the comment docs.

@msakrejda
Copy link
Contributor

The warning is not terribly actionable and comes after an irreversible operation... What's our goal here? Can/should we warn before the action? Can we link to more information on follower lag?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants