This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
fix: force exit after psql closes #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 95.23% 95.16% -0.07%
==========================================
Files 55 55
Lines 1365 1366 +1
==========================================
Hits 1300 1300
- Misses 65 66 +1
Continue to review full report at Codecov.
|
msakrejda
approved these changes
May 18, 2018
| @@ -17,6 +17,9 @@ function * run (context, heroku) { | |||
| process.stdout.write(yield psql.exec(db, flags.command)) | |||
| } else { | |||
| yield psql.interactive(db) | |||
| // sometimes psql hangs and causes the stdout "drain" event not to be fired in cli-ux | |||
| // so we force an exit here | |||
| cli.exit(0) | |||
There was a problem hiding this comment.
So the issue is that the CLI is waiting for a stdout event that is not coming? That is, we want to ensure that once psql exits, the command is done and any pending background processing is moot?
There was a problem hiding this comment.
yeah exactly. It's strange that this doesn't have anything to do with stdout really, the issue is that somewhere in the code path some node task is starting and not quitting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.