This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The checklist enumerates the tasks you set out to do before the PR becomes ready for review
Why
We want to encourage users to set a single ownership model in their pipelines. The metrics around this command proved that it was worth adding a warning message advising them about this situation when proceeds.
This warning is only added to the
pipelines:info
command as it'd be API expensive to check pipeline coupling ownership in other commands which would slow down the experience considerably.What are the acceptance criteria for the change?
How can the change be tested
Download this code
Run it locally doing
heroku plugins:link .
Run
heroku pipelines:info
in a pipeline you think it's suspicious of being in this situation.enumerate a list of steps that the reviewer may step through to fully experience the changeset being introduced
Demonstration
Who's Affected
Users with apps in a pipeline owned by different users/teams.
Blockers & upstream dependencies
None.