Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Show mixed ownership warning #72

Merged
merged 3 commits into from
Sep 11, 2017
Merged

Show mixed ownership warning #72

merged 3 commits into from
Sep 11, 2017

Conversation

raulb
Copy link
Contributor

@raulb raulb commented Sep 8, 2017

Checklist

The checklist enumerates the tasks you set out to do before the PR becomes ready for review

Why

We want to encourage users to set a single ownership model in their pipelines. The metrics around this command proved that it was worth adding a warning message advising them about this situation when proceeds.

This warning is only added to the pipelines:info command as it'd be API expensive to check pipeline coupling ownership in other commands which would slow down the experience considerably.

What are the acceptance criteria for the change?

How can the change be tested

  • Download this code

  • Run it locally doing heroku plugins:link .

  • Run heroku pipelines:info in a pipeline you think it's suspicious of being in this situation.

  • enumerate a list of steps that the reviewer may step through to fully experience the changeset being introduced

Demonstration

β€Ί heroku pipelines:info my-mixed-pipeline
name:  my-mixed-pipeline
owner: my-team (team)

app name          stage
──────────────    ───────
β¬’ one-app         staging
β¬’ another-app     staging

 β–Έ    Some apps in this pipeline do not belong to my-team (team).
 β–Έ
 β–Έ    All apps in a pipeline must have the same owner as the pipeline owner.
 β–Έ    Transfer these apps or change the pipeline owner in pipeline settings.
 β–Έ    See https://devcenter.heroku.com/articles/pipeline-ownership-transition for more info.

Who's Affected

Users with apps in a pipeline owned by different users/teams.

Blockers & upstream dependencies

None.

@raulb raulb requested a review from a team September 8, 2017 17:00
@raulb raulb merged commit 4512ac2 into master Sep 11, 2017
@raulb raulb deleted the show-mixed-ownership-warning branch September 11, 2017 07:52
raulb added a commit that referenced this pull request Sep 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants