Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo:purge_cache when there is nothing to purge #36

Closed
cyx opened this issue Feb 11, 2015 · 3 comments
Closed

repo:purge_cache when there is nothing to purge #36

cyx opened this issue Feb 11, 2015 · 3 comments

Comments

@cyx
Copy link

cyx commented Feb 11, 2015

If for some reason the cache_get_url results in a 404 (maybe due to an old version of the plugin being used), we get a cryptic error when running the command.

Perhaps we can just silently fail / run without showing any errors for cases like this.

@edmorley
Copy link
Member

edmorley commented Oct 5, 2017

This is fixed in the new builds:cache:purge command added to heroku-builds that is replacing the repo:purge_cache command in this repo (see #77):

treeherder $ ths builds:cache:purge
Purging build cache for treeherder-stage... done
treeherder $ ths builds:cache:purge
Purging build cache for treeherder-stage... done

(ths is an alias for HEROKU_APP=treeherder-stage heroku)

As such, I think this can now be closed.

@dmathieu
Copy link
Contributor

dmathieu commented Oct 5, 2017

Thank you @edmorley

@dmathieu dmathieu closed this as completed Oct 5, 2017
@econner
Copy link

econner commented Jun 21, 2019

Hello from 2019. Are we not supposed to be using the purge_cache command in heroku repo? As of 2017 it was going to be replaced?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants