Update for API v3 #76
Conversation
* Updated library versions * Removed support for Play * Added encode impl for Gson * Removed unused deprecated code * Refactor jersey-client to use ApacheConnectorProvider to support PATCH * Add encode support to Json providers * Changed app Accept headers to JSON
* Use oracle jdk8 * Revised travis test config * Update travis keys * Remove old keys
| @@ -8,3 +8,4 @@ | |||
| target | |||
| .DS_Store | |||
| *.versionsBackup | |||
| *.jkutner.profile | |||
There was a problem hiding this comment.
This could probably just go in your global gitignore.
| @@ -5,7 +5,7 @@ | |||
| <parent> | |||
| <artifactId>heroku-api-parent</artifactId> | |||
| <groupId>com.heroku.api</groupId> | |||
| <version>0.17-SNAPSHOT</version> | |||
| <version>3.0.0-SNAPSHOT</version> | |||
There was a problem hiding this comment.
That's a pretty big jump. Is 3.0 used because you want to match the API versioning?
There was a problem hiding this comment.
Yea, 3.0 to match the API. But also because a bump to 1.0 didn't seem right. idk. i don't have a strong opinion on this. got a better suggestion? just 0.18?
There was a problem hiding this comment.
I don't have a strong opinion either, just trying to understand. At one point we didn't want to pin the heroku.jar version to the API version, but don't remember why. Also, this library technically works with both v2 and v3 of the API.
| @@ -274,7 +270,7 @@ public String getHeaderName() { | |||
|
|
|||
| @Override | |||
| public String getHeaderValue() { | |||
| return Integer.toString(version); | |||
| return "application/vnd.heroku+json; version=" + Integer.toString(version); | |||
There was a problem hiding this comment.
While you're touching this, you might want to include the ability to set the version's variant.
|
👍 |
|
Thanks @jkutner ! Just saw this 😄 |
This update is intended to convert the library to API v3, while maintaining backwards compatibility as much as possible. In the future, a 3.1.0 release will update the class structure to more accurately match what is presented in the Platform API. We also rename library, such as the ning-async to match the newer asynch-httpclient, which is actually used.