Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Commit

Permalink
make heroku-accounts warning much more obvious
Browse files Browse the repository at this point in the history
It will not work with http-git or any new commands. It isn't being
maintained, but with how new commands work there isn't a way for the
plugin to function even if it had a maintainer.
  • Loading branch information
dickeyxxx committed Sep 14, 2015
1 parent e7c4dd9 commit 90a3142
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/heroku/auth.rb
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ def ask_for_password
end

def ask_for_and_save_credentials
warn "WARNING: heroku-accounts plugin is installed. This plugin is known to have problems with HTTP Git." if defined?(Heroku::Command::Accounts)
@credentials = ask_for_credentials
debug "Logged in as #{@credentials[0]} with key: #{@credentials[1][0,6]}..."
write_credentials
Expand Down
4 changes: 4 additions & 0 deletions lib/heroku/cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def self.start(*args)
require 'heroku/command'
Heroku::Git.check_git_version
Heroku::Command.load
warn_if_using_heroku_accounts
Heroku::Command.run(command, args)
Heroku::Updater.autoupdate
rescue Errno::EPIPE => e
Expand All @@ -40,4 +41,7 @@ def self.start(*args)
exit(1)
end

def self.warn_if_using_heroku_accounts
warn "WARNING: deprecated ddollar/heroku-accounts plugin is installed." if defined?(Heroku::Command::Accounts)
end
end

0 comments on commit 90a3142

Please sign in to comment.