Full rewrite to get rid of ThreadSafe wrapper #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dang, used the wrong account to create the RP. Still works though :) |
stevenharman
reviewed
May 7, 2019
l2meter.gemspec
Outdated
| spec.add_development_dependency "pry-byebug" | ||
| spec.add_development_dependency "rake" | ||
| spec.add_development_dependency "rspec", "~> 3.8.0" | ||
| spec.add_development_dependency "timecop" |
There was a problem hiding this comment.
Any specific reason to pull these back out of here, rather than sticking with the recommendation of RubyGems and keeping them here? eb0cf41#commitcomment-33404223
There was a problem hiding this comment.
Oh, I've just reverted the commit to make the CI green. This commit has nothing to do with the intent of the PR
There was a problem hiding this comment.
👍 I think the bundler failures are caused by running on the older Travis infra. I've upgraded other Gems to the Xenial image and it ✨magically works ✨. Though I'm still unsure why. Need to dig into that another day.
stevenharman
added a commit
that referenced
this pull request
Jul 26, 2021
As part of [#7](#7) we lost the ability to totally disable the logger, across all threads. It's unclear if this was intentional, but I am guessing it was not. This will restore the behavior by returning a new `NullOutput` instance when trying to write while disabled. This might cause A LOT of object allocations, all with short lives. Hopefully. If so, we could consider some form of memoization of the instance.
stevenharman
added a commit
that referenced
this pull request
Jul 26, 2021
As part of [#7](#7) we lost the ability to totally disable the logger, across all threads. It's unclear if this was intentional, but I am guessing it was not. This will restore the behavior by returning a new `NullOutput` instance when trying to write while disabled. This might cause A LOT of object allocations, all with short lives. Hopefully. If so, we could consider some form of memoization of the instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #6 and prevent memory leaks.