Unable to manage config vars w/ "." character #470

Closed
rwdaigle opened this Issue Jul 19, 2012 · 5 comments

Projects

None yet

2 participants

@rwdaigle
Contributor
$ heroku config | grep MAINTENANCE
MAINTENANCE_PAGE_URL.bkp:   http://testpage.com/error.html

$ heroku config:remove MAINTENANCE_PAGE_URL.bkp
Unsetting MAINTENANCE_PAGE_URL.bkp and restarting ptls... failed
 !    Not found

Quoting the value doesn't seem to help either.

$ heroku config:remove "MAINTENANCE_PAGE_URL.bkp"
Unsetting MAINTENANCE_PAGE_URL.bkp and restarting ptls... failed
 !    Not found
@geemus
Member
geemus commented Jul 19, 2012

@rwdaigle - How was the . value created? I think probably the client will need to quote these before sending them across the wire.

@rwdaigle
Contributor

Doesn't seem to help?

$ heroku config:add "test.meagain"=foobar
Setting config vars and restarting ptls... done, v110
test.meagain: foobar
$ heroku config:remove test.meagain
Unsetting test.meagain and restarting ptls... failed
 !    Not found
$ heroku config:remove "test.meagain"
Unsetting test.meagain and restarting ptls... failed
 !    Not found
@geemus
Member
geemus commented Jul 19, 2012

Sorry, I was entirely to vague. When I said client I meant the source code within heroku.rb (not the end user). I'm kind of surprised that it gets created sensibly in the first place.

@rwdaigle
Contributor

I believe it was created programmatically with the heroku gem invoked from a rake task.

@geemus
Member
geemus commented Jul 19, 2012

Ah ha, its because creation of config_vars uses post/query params (which wouldn't need escaping) vs a url segment for remove (which would need escaping). I believe this should fix the problem: heroku/heroku.rb@886f688

@geemus geemus closed this Jul 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment