This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
spaces: don't use platform api dogwood variant #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The platform api dogwood variant is getting merged into prod v3. We don't need to make calls to the platform api requesting the variant for dogwood-specific properties of organizations, regions, or spaces. Calls to prod v3 will return the same properties now.
|
lgtm |
Platform api requests that don't specify a version will default to v2. We want requests that return information about spaces or org apps to go to v3 instead
jsullivan
force-pushed
the
no-need-for-dowgood-variant
branch
from
bac10df
to
66b8e32
Compare
|
I added one more commit to this PR after @dickeyxxx and I remembered that we still need to specify version 3 for any requests that return information about spaces and org apps. Might be worth a final once over before merging this in. Other than that, the platform api deploy that was blocking this PR is done so this can be merged whenever. |
jdx
pushed a commit
that referenced
this pull request
Dec 1, 2015
spaces: don't use platform api dogwood variant
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform api dogwood variant is merging into prod v3. We don't need to make calls to the platform api requesting the variant for dogwood-specific properties of organizations, regions, or spaces. Calls to prod v3 will return the same properties now.
*Note: please don't merge and deploy these changes until heroku/api#5162 has been merged and deployed.