This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
"comparison of String with 1 failed (ArgumentError)" when running 'heroku dynos x' #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that in the specs :set_dynos was stubed to return 7 (Fixnum), but in the real implementation it returns "7" (String). So I fixed the specs to return "7", and I also added specs for workers and the 3 different cases for the pluralization of "dynos" and "workers" in the outputted sentence. Also added a spec for Heroku::Client#set_workers.
|
Any interest in that ? Are we the only one getting this error ? |
|
Still no interest in a fix and new specs? |
|
Sorry, I missed this request because notifications weren't set up properly. This should be fixed. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed that error that was occurring only when actually using the command line because in the specs Heroku::Client#set_dynos was stubbed to return a Fixnum when the real implementation is returning a String.