Send EOF to the remote on input EOF

[dividedmind]

Attached patch sends 4.chr to the remote on input EOF. It finally makes it possible to pipe stuff to heroku run. Fixes issue #256

[dividedmind]

A friendly reminder. (Failed tests seem unrelated.)

[opsb]

This would be so useful, please merge it in :)

[wuputah]

Thanks!

[ejfinneran]

Do you know if this will also fix #674?

[wuputah]

Not sure.

[dividedmind]

Thanks for merging!

(As for #674, I'm afraid it won't fix it, it looks totally unrelated.)

[pedro]

Is this supposed to work?

$ echo ls | heroku run bash

ls is pipped in, but the run session gets stuck after that.

[wuputah]

I think there is still a bug here about stdin/stdout being non-interactive (not being a tty) - that status is not being passed to the recipient process, so you're seeing weird behavior. I think that would be fixed by passing an empty ps_env in this case but I'm not sure. I don't have this issue when using the API + rendezvous directly:
https://gist.github.com/wuputah/5880052

[dividedmind]

Yeah, the problem is with bash -- actually libreadline -- detecting a terminal and trying to handle it itself. You can work around this by turning off libreadline with --noediting switch:

$ echo ls | heroku run bash --noediting -a divide
Running `bash --noediting` attached to terminal... up, run.4276
ls
~ $ ~ $ exit
$

[pre]

Moved my comment to the open issue #1409