add cross-compilation assistance for linux aarch64 #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hone
force-pushed
the
libcnb-package/aarch64
branch
from
21ebda7
to
53f3283
Compare
Malax
reviewed
Jun 21, 2023
Malax
approved these changes
Jun 21, 2023
hone
force-pushed
the
libcnb-package/aarch64
branch
from
89391ad
to
6ff05ef
Compare
Merged
edmorley
reviewed
Nov 8, 2023
| @@ -59,6 +59,31 @@ The easiest way to install 'musl-gcc' is to install the 'musl-tools' package: | |||
| - https://packages.debian.org/bullseye/musl-tools"#, | |||
| )), | |||
| } | |||
| } else if target_triple.as_ref() == AARCH64_UNKNOWN_LINUX_MUSL && cfg!(target_os = "linux") { | |||
| let gcc_binary_path = "aarch64-linux-gnu-gcc"; | |||
There was a problem hiding this comment.
@hone Was there a reason this is aarch64-linux-gnu-gcc not aarch64-linux-musl-gcc? We're using MUSL for everything else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to cross-compile to aarch64 on Linux,
cargoneeds some guidance to find the compiler and linker.