Switch to the zlib flate2 decompression backend #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
added
examples
faster tests
The `flate2` crate supports multiple backends for performing decompression: https://github.com/rust-lang/flate2-rs#backends The default `miniz_oxide` flate2 backend has poor performance in debug builds/under QEMU: rust-lang/flate2-rs#297 Ideally we'd use the fastest `zlib-ng` backend, however it fails to cross-compile: rust-lang/libz-sys#93 As such we have to use the next best alternate backend, which is the `zlib` backend. (This is the backend that the Python CNB already uses.) GUS-W-13745779.
edmorley
force-pushed
the
edmorley/flate2-zlib
branch
from
5147dcd
to
c45a200
Compare
dzuelke
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
flate2crate supports multiple backends for performing decompression:https://github.com/rust-lang/flate2-rs#backends
The default
miniz_oxideflate2 backend has poor performance in debug builds/under QEMU:rust-lang/flate2-rs#297
Ideally we'd use the fastest
zlib-ngbackend, however it fails to cross-compile:rust-lang/libz-sys#93
As such we have to use the next best alternate backend, which is the
zlibbackend.(This is the backend that the Python CNB already uses.)
GUS-W-13745779.