Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use inspect_err for tracing errors #774

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Use inspect_err for tracing errors #774

merged 2 commits into from
Feb 8, 2024

Conversation

Malax
Copy link
Member

@Malax Malax commented Feb 8, 2024 •
edited

With Rust 1.76 now out, Result::inspect_err is stable! Using it over Resut::map_err un-clutters the tracing code a lot. This PR will bump the MSRV to 1.76.

@Malax Malax added the libcnb label Feb 8, 2024
@Malax Malax marked this pull request as ready for review February 8, 2024 16:48
@Malax Malax requested a review from a team as a code owner February 8, 2024 16:48
joshwlewis
joshwlewis approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@joshwlewis joshwlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

edmorley
edmorley approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this - you beat me to it! (A few weeks ago I'd set a reminder for tomorrow morning to make this change, post 1.76 release :-))

README.md Show resolved Hide resolved
@Malax Malax enabled auto-merge (squash) February 8, 2024 17:19
@Malax Malax merged commit e12a6e7 into main Feb 8, 2024
4 checks passed
@Malax Malax deleted the malax/use-inspect-err branch February 8, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

@joshwlewis joshwlewis joshwlewis approved these changes

Assignees

@Malax Malax

Labels
libcnb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Malax @edmorley @joshwlewis