Make the run image Target public
#815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `ContextTarget` (the type of `DetectContext::target` and `BuildContext::target`) was private, so couldn't be used by buildpacks migrating from stacks to targets. It's now been made public, and also renamed to the slightly clearer `Target`. Since it wasn't public before, this rename isn't a breaking change. However, that means we now have two `Target`s, since `libcnb-data` has a `buildpack::Target`. Since the latter will be much less frequently used (and most of the other `buildpack::*` types are prefixed, eg `BuildpackId`, `BuildpackVersion` etc), I've renamed the `libcnb-data` type to `BuildpackTarget` to disambiguate it.
Malax
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
ContextTarget(the type ofDetectContext::targetandBuildContext::target) was private, so couldn't be used by buildpacks migrating from stacks to targets.It's now been made public, and also renamed to the slightly clearer
Target. Since it wasn't public before, this rename on its own isn't a breaking change.However, that means we now have two
Targets, sincelibcnb-datahas abuildpack::Target. Since the latter will be much less frequently used (and most of the otherbuildpack::*types are prefixed, egBuildpackId,BuildpackVersionetc), I've renamed thelibcnb-datatype toBuildpackTargetto disambiguate it (which is a breaking change).Lastly, since
ContextTargetwas never public, I've removed the existing changelog entry mentioning fixing the wording of the rustdocs (since the rustdocs weren't visible before).GUS-W-15468609.