Add better resizing

Always resize *up* after a connection iff the log buffer is smaller than the current default value for the buffer.
heroku · Nov 11, 2013 · 3386377 · 3386377
1 parent ffe84cb
commit 3386377
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/logplex_tcpsyslog_drain.erl b/src/logplex_tcpsyslog_drain.erl
@@ -561,8 +561,9 @@ target_send_size() ->
     end.
 
 maybe_resize(Buf) ->
-    case logplex_msg_buffer:max_size(Buf) =:= ?SHRINK_BUF_SIZE of
+    Default = default_buf_size(),
-        true -> logplex_msg_buffer:resize(default_buf_size(), Buf);
+    case logplex_msg_buffer:max_size(Buf) < Default of
+        true -> logplex_msg_buffer:resize(Default, Buf);
         false -> Buf
     end.
 

diff --git a/test/logplex_tcp_drain_SUITE.erl b/test/logplex_tcp_drain_SUITE.erl
@@ -181,6 +181,8 @@ full_stack(Config) ->
     {match, _} = re:run(Logs, "mymsg7").
 
 shrink(Config) ->
+    %% Use an explicitly larger default than whatever the suite sets
+    application:set_env(logplex, tcp_drain_buffer_size, 1024),
     Msg = fun(M) -> {user, debug, logplex_syslog_utils:datetime(now),
                      "fakehost", "erlang", M}
     end,