Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem not updated with the latest code #7

Closed
gavingmiller opened this issue Oct 7, 2013 · 7 comments
Closed

Gem not updated with the latest code #7

gavingmiller opened this issue Oct 7, 2013 · 7 comments

Comments

@gavingmiller
Copy link

Ran across an issue trying to set log level via config/environments/production.rb not being respected by the rails_stdout_logging gem. The code in master is setup to allow this, but you've not updated the gem with this change. Can you please do so? 😃

Thanks for the great work!

Temporary workaround is to set ENV['LOG_LEVEL'] on heroku.

@schneems
Copy link
Contributor

schneems commented Oct 7, 2013

Version 0.0.2 was released with this code change in August: http://rubygems.org/gems/rails_stdout_logging/versions/0.0.2

New installs of rails_12factor and rails_stdout_logging should be getting the correct code.

If not you may need to $ bundle update rails_stdout_logging on your project.

@schneems schneems closed this as completed Oct 7, 2013
@gavingmiller
Copy link
Author

I believe you're incorrect. The code as of August 30 is here and the specific lines in question read as:

def self.log_level
  ([ENV['LOG_LEVEL'].to_s.upcase, "INFO"] & %w[DEBUG INFO WARN ERROR FATAL UNKNOWN]).compact.first
end

There is no reference to the Rails.config, only to the environment log level. The change to resolve this issue occurred on Sept 5th. So the current gem is outdated with what's on master.

@schneems schneems reopened this Oct 7, 2013
@schneems
Copy link
Contributor

schneems commented Oct 7, 2013

I believe you're incorrect

I believe you're correct on that one.

Sorry I mis-understood the reference. This change was merged when I was away for several days at funeral. I forgot to cut a release. I'll look into doing that soon. Thanks for opening the issue! ❤️

@gavingmiller
Copy link
Author

No worries. Thanks for looking into it further. 👍

@hone
Copy link
Member

hone commented Oct 8, 2013

Just cut v0.0.3

@hone hone closed this as completed Oct 8, 2013
@schneems
Copy link
Contributor

schneems commented Oct 8, 2013

thanks @hone ❤️ do you even sleep bro?

@hone
Copy link
Member

hone commented Oct 8, 2013

:) I got a few hours in before planning meeting.

On Tue, Oct 8, 2013 at 12:15 PM, Richard Schneeman <notifications@github.com

wrote:

thanks @hone https://github.com/hone [image: ❤️] do you even sleep
bro?


Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-25904461
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants