#58 Added wrappedInstance to the meta object #139
Conversation
|
fixes #58 |
| @@ -279,6 +279,7 @@ function connect(mapPropsToRequestsToProps, defaults, options) { | |||
| } else { | |||
| const request = mapping.buildRequest(mapping) | |||
| meta.request = request | |||
| meta.component = this.refs.wrappedInstance | |||
There was a problem hiding this comment.
this should probably be done right after line 267 (or something like const meta = Object.assign(meta, {component: this.refs.wrappedInstance}) so that identity requests and regular fetches (i.e. the branches of the if/else) are treated the same in this regard.
|
Thanks for opening this. Would you also be able to add a test (there's probably an existing one that can be easily modified), add it to the API doc, and perhaps add an example? |
| @@ -22,6 +22,7 @@ Instead, it *returns* a new, connected component class, for you to use. | |||
| - `force` *(Boolean)*: Forces the data to be always fetched when new props are received. Takes precedence over `comparison`. | |||
| - `comparison` *(Any)*: Custom value for comparing this request and the previous request when the props change. If the `comparison` values are *not* strictly equal, the data will be fetched again. In general, it is preferred to rely on the default that compares material changes to the request (i.e. URL, headers, body, etc); however, this is helpful in cases where the request should or should not be fetched again based on some other value. If `force` is true, `comparison` is not considered. | |||
| - `then(value, meta): request` *(Function)*: returns a request to fetch after fulfillment of this request and replaces this request. Takes the `value` and `meta` of this request as arguments. Return `undefined` in `then` to do side-effects after a successful request, leaving the request as is. | |||
| - `meta` is an object with keys `{ request, response, component, ...<your meta>}` where `component` is equal to the wrappedInstance. You can use it to create side effects on promise fulfillment. e.g. `then(value, meta) { meta.component.onDataLoaded(value); }` | |||
There was a problem hiding this comment.
only if you passed withRef: true to options, otherwise component will be undefined
There was a problem hiding this comment.
Good point. I'll add this note after merging.
There was a problem hiding this comment.
Good point. I'll add this note after merging.
|
Thanks @eyalw ! |
|
I was just doing a quick test of this in a real app and got: I haven't taken the time to dig in, but just wanted to check with @eyalw if you had this happen when using |
|
I didn't, an odd message. Do you have a short code that duplicated the
|
|
@ryanbrainard are you releasing a new beta with this code soon? |
|
@eyalw Oh, yes, sorry, I can cut a release |
Added wrappedInstance to the meta object for side effects during then() and andThen().
the wrappedInstance is called just "component" in the context of then() because I thought it would be a simpler name yet clear enough.