Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated lifecycle hooks, context, and pure #233

Merged
merged 14 commits into from
Oct 10, 2019

Conversation

ryanbrainard
Copy link
Contributor

Builds upon #217 to fix #217 and #231.

This moves from the deprecated componentWillMount and componentWillReceiveProps to componentDidMount and componentDidUpdate. To also moves away from the deprecated context. To support this, the pure option is also removed to avoid infinite loops in the setting state.

Unit tests have been updated and a light exploratory testing have been done on a real app, but more of the latter likely needs to be done. I have cut 3.0.0-0 beta for this if anyone wants to take it for a spin.

Copy link

@spicysouvlaki spicysouvlaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for a beta. I'd like to see us try it out for a little while before a 3.0.1. We probably also need to come back and update the README and other docs at that point too.

@ryanbrainard ryanbrainard merged commit 6f26d9a into master Oct 10, 2019
@ryanbrainard ryanbrainard deleted the tkvw-remove-deprecation branch October 10, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants