Ability for heroku_team_collaborator to handle users that already exist on the app
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mars Thoughts on this? |
mars
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
This looks good @davidji99 👍 I really appreciate these little adaptations to make Terraform cooperate with external configuration changes.
… an app By checking the error response of the API response received from resource creation. If the error contains a certain string, find and set existing collaborator ID to resource ID.
davidji99
force-pushed
the
heroku-team-collabor-enhancement
branch
from
373e055
to
08c153b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my experience, people often manually add users to Heroku team apps outside of Terraform for a number of reasons. When the Terraform configuration is updated to reflect such out-of-band changes, people need to
importthe resource first before executing anapply. This PR will handle this scenario but checking for a specific error returned from resource creation indicating that the target user is on the target app. If so, find the collaborator ID, set it to the resource ID, and proceed with state refresh.