vegur_client:stream_header connection header parsing #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypaq
reviewed
May 5, 2017
| @@ -690,7 +690,8 @@ stream_header(Client=#client{state=State, buffer=Buffer, | |||
| end | |||
| end; | |||
| <<"connection">> -> | |||
| Values = header_list_values(Value), | |||
There was a problem hiding this comment.
Would propose to get rid of header_list_values as it is only used in one other place. Also wondering if we can test this?
There was a problem hiding this comment.
Yeah, can remove that function for sure.
It doesn't look like there's an existing test, adding one would be a lot of work to prove we're no longer hitting a bad arg in an edge case.
connection header parsing shouldn't crash on empty header value.
joedevivo
force-pushed
the
jd/allow-empty-list-connection-header
branch
from
ac9ccd8
to
c54de4f
Compare
|
Ok, works for me.
…On Fri, May 5, 2017, 12:04 PM Joe DeVivo ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/vegur_client.erl
<#176 (comment)>:
> @@ -690,7 +690,8 @@ stream_header(Client=#client{state=State, buffer=Buffer,
end
end;
<<"connection">> ->
- Values = header_list_values(Value),
Yeah, can remove that function for sure.
It doesn't look like there's an existing test, adding one would be a lot
of work to prove we're no longer hitting a bad arg in an edge case.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#176 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB1Mpzkr4GdjDOI0ow-rEwJCmpVwQvLqks5r23K7gaJpZM4NSRfa>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connection header parsing shouldn't crash on empty header value.