Skip to content

Commit

Permalink
Merge pull request #190 from heroku/export-multiprovider-cardinality-…
Browse files Browse the repository at this point in the history
…counter

With this change, we export the `multiprovider.MultiCardinalityCounter`. This more closely matches go-kit's `multi` package in which the underlying metric instruments in the slice are still accessible: https://pkg.go.dev/github.com/go-kit/kit@v0.12.0/metrics/multi#Counter.
  • Loading branch information
slizco committed Apr 4, 2023
2 parents 38eb879 + fd6b610 commit 6cc0b61
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions go-kit/metrics/multiprovider/multiprovider.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func (m *multiProvider) NewCardinalityCounter(name string) metrics.CardinalityCo
for _, p := range m.providers {
cardCounters = append(cardCounters, p.NewCardinalityCounter(name))
}
return multiCardinalityCounter(cardCounters)
return MultiCardinalityCounter(cardCounters)
}

// Stop calls stop on all the underlying providers.
Expand Down Expand Up @@ -99,17 +99,17 @@ func (m *multiProvider) Flush() error {
return errors.Errorf("flush failed for at least one provider: %s", strings.Join(errMsgs, ";"))
}

type multiCardinalityCounter []metrics.CardinalityCounter
type MultiCardinalityCounter []metrics.CardinalityCounter

func (cc multiCardinalityCounter) With(labelValues ...string) metrics.CardinalityCounter {
func (cc MultiCardinalityCounter) With(labelValues ...string) metrics.CardinalityCounter {
cardCounters := make([]metrics.CardinalityCounter, 0, len(cc))
for _, cardCounter := range cc {
cardCounters = append(cardCounters, cardCounter.With(labelValues...))
}
return multiCardinalityCounter(cardCounters)
return MultiCardinalityCounter(cardCounters)
}

func (cc multiCardinalityCounter) Insert(b []byte) {
func (cc MultiCardinalityCounter) Insert(b []byte) {
for _, cardCounter := range cc {
cardCounter.Insert(b)
}
Expand Down

0 comments on commit 6cc0b61

Please sign in to comment.