Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseLayerCombo - API params not working correct #234

Closed
GoogleCodeExporter opened this issue May 10, 2015 · 4 comments
Closed

BaseLayerCombo - API params not working correct #234

GoogleCodeExporter opened this issue May 10, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

With rev786 the code of the BaseLayerCombo was changed completly from 
'Ext.extend(Ext.form.ComboBox)' to 'Ext.extend(Heron.widgets.LayerCombo)'.

1.)
From that on no parameter given to the 'ToolbarBuilder' (like 'width' or 
'listWidth') have any affect: all API params are ignored.

Heron.options.map.toolbar = [
    {type: "scale", options: {width: 110}},
    {type: "-"} ,
    {type: "baselayer", options: {width: 150, listWidth: 150}},
    {type: "-"} ,
...

2.)
The API documentation for 'BaseLayerCombo' points to the old declarations.

3.)
Examing the assigned 'LayerCombo' code shows, that the params 'width' and 
'listWidth' are not working correct, when the parameters are numeric (like 
'width = 150') => the list changed to the 'auto' mode!


Original issue reported on code.google.com by wolfram.winter on 14 Jun 2013 at 9:07

@GoogleCodeExporter
Copy link
Author

The LayerCombo class that extends Ext.form.ComboBox, was introduced in v0.73 as 
for search forms we needed multiple variants of Layer choosers. The actual set 
of Layers is now determined by a LayerFilter.  The BaseLayerCombo extends 
LayerCombo with basically only a specialized Layer filter (to filter out only 
base Layers). I tried to make BaseLayerCombo working still the same way as 
before but appearantly did not succeed. 

One of the main problems I encountered was that there were bugs in Ext 
LayerCombo w.r.t. width and listWidth when the box values were unknown at 
creation. Also IE seems to ignore value like 'auto'. See for example 
http://stackoverflow.com/questions/1459221/extjs-ext-combobox-autosize-over-exis
ting-content

I will look further into what is happening.



Original comment by jus...@gmail.com on 17 Jun 2013 at 8:29

@GoogleCodeExporter
Copy link
Author

Ok, width and listWidth setting should work again. There was a problem with 
assigning config values in this particular case. But best is to assign no 
width. Then the default 'auto' will be assigned and the names will always fit. 
Or you could make widt a fixed value and have listWidth 'auto'.

Tested with example: 
http://lib.heron-mc.org/heron/latest/examples/baselayercombo and checked-in, 
let me know if this works so we can close this issue.



Original comment by jus...@gmail.com on 17 Jun 2013 at 11:34

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by jus...@gmail.com on 17 Jun 2013 at 11:35

  • Added labels: Milestone-Release0.74, OpSys-All, Project-BahnDE

@GoogleCodeExporter
Copy link
Author

I think it's ok. now.

Original comment by wolfram.winter on 19 Jun 2013 at 6:38

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant