Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Issue with latest update arms warrior no longer supported #1054

Closed
J603 opened this issue May 5, 2024 · 2 comments
Closed

[Bug]: Issue with latest update arms warrior no longer supported #1054

J603 opened this issue May 5, 2024 · 2 comments
Assignees

Comments

@J603
Copy link

J603 commented May 5, 2024

What version of HeroRotation are you using?

10.2.6.18

What version of HeroLib are you using?

10.2.6.02

What version of HeroDBC are you using?

10.2.6.03

What is the issue?

Message: Interface/AddOns/HeroRotation_Warrior/Arms.lua:438: '' expected near ')'
Time: Sun May 5 19:27:53 2024
Count: 1
Stack: Interface/AddOns/HeroRotation_Warrior/Arms.lua:438: '' expected near ')'
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'

[string "@Interface/AddOns/HeroRotation/Main.lua"]:395: in function `PulseInit'
Message: Interface/AddOns/HeroRotation_Warrior/Arms.lua:1 Interface/AddOns/HeroRotation_Warrior/Arms.lua:438: '' expected near ')'
Time: Sun May 5 19:27:53 2024
Count: 2
[string "@Interface/AddOns/HeroRotation/Main.lua"]:303: in function <Interface/AddOns/HeroRotation/Main.lua:300>

Locals: (*temporary) = defined =[C]:-1

Icon Behavior

Icon does NOT disappear

@J603 J603 added the Bug label May 5, 2024
@neogia
Copy link

neogia commented May 5, 2024

if S.Whirlwind:IsReady() and (S.StormofSwords:IsAvailable() and not S.TestofMight:IsAvailable().) then

Looks like just an extra period in this conditional was added in yesterday's patch. This changed line fixed it for me.
if S.Whirlwind:IsReady() and (S.StormofSwords:IsAvailable() and not S.TestofMight:IsAvailable()) then

@Cilraaz Cilraaz self-assigned this May 5, 2024
@Cilraaz Cilraaz added the Fixed label May 5, 2024
@Cilraaz
Copy link
Contributor

Cilraaz commented May 5, 2024

This has been fixed in commit eb543ff which will be included in release version 10.2.6.19.

@Cilraaz Cilraaz closed this as completed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants