Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Hero work with TableViews or CollectionViews? #36

Closed
jdisho opened this issue Jan 10, 2017 · 3 comments
Closed

Does Hero work with TableViews or CollectionViews? #36

jdisho opened this issue Jan 10, 2017 · 3 comments

Comments

@jdisho
Copy link

jdisho commented Jan 10, 2017

When I click on a cell on a TableView or CollectionView the animation is perfect, but when I press the back button the TableView goes under the NavigationBar.
Hero is Enabled to true btw.

screen shot 2017-01-10 at 22 18 04

@lkzhao
Copy link
Collaborator

lkzhao commented Jan 10, 2017

Shouldn't happen. Might be a bug. If you disable Hero, does the problem go away? Can you provide a demo project so that I can better help you?

@jdisho
Copy link
Author

jdisho commented Jan 11, 2017

When I disable Hero the problem goes away...
The navigation bar that you see is a custom navBar and a question that pops in my head now is if Hero supports custom navigation bars (this navBar is from Material Design ) ?.
Here is a short demo of the problem.

Demo.zip

Thank you for the awesome framework 🥇

@lkzhao
Copy link
Collaborator

lkzhao commented Jan 11, 2017

Should be fixed with this: 715610a

Apparently, the Material project doesn't support insets according to the layout guide. That is different from the default UINavigationController. But I should't have set the frame of the destination view controller either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants