Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero modifiers don't affect transition #47

Closed
vkaramov opened this issue Jan 18, 2017 · 5 comments
Closed

Hero modifiers don't affect transition #47

vkaramov opened this issue Jan 18, 2017 · 5 comments

Comments

@vkaramov
Copy link

vkaramov commented Jan 18, 2017

I have removed Hero modifiers from the Demo App, one-by-one and didn't notice any difference in the App behavior running in iPhone 5(iOS 9.0) Simulator.

@lkzhao
Copy link
Collaborator

lkzhao commented Jan 19, 2017

They should. Are you still experiencing this?

@vkaramov
Copy link
Author

Yes. Could you please give me an example where can I see the difference?

@lkzhao
Copy link
Collaborator

lkzhao commented Jan 19, 2017

In the first example: Basic. if you remove the arc modifier, you will see that the squares go directly to their destination. Note that you will have to remove the destination views' modifier.

@vkaramov
Copy link
Author

Are you going to provide some documentation regarding modifiers? I'm wondering how, how example, zPosition works.

@lkzhao
Copy link
Collaborator

lkzhao commented Jan 20, 2017

You can alt+click on the modifier in code to see the header doc. Or you can checkout the usage guide. https://github.com/lkzhao/Hero/wiki/Usage-Guide#zposition-modifier

@lkzhao lkzhao closed this as completed Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants