Merge pull request doctrine#10 from Baachi/master

Update response class
herrsebi · Oct 30, 2011 · 94e0bd1 · 94e0bd1
2 parents 9f2d2d5 + a0ab559
commit 94e0bd1
Show file tree

Hide file tree

Showing 5 changed files with 51 additions and 7 deletions.
diff --git a/lib/Doctrine/Search/Http/Response.php b/lib/Doctrine/Search/Http/Response.php
@@ -3,7 +3,25 @@
 
 interface Response
 {
+    /**
+     * Get the statuscode
+     *
+     * @return int
+     */
+    public function getStatusCode();
+
+    /**
+     * @return bool
+     */
+    public function isSuccessfull();
+
+    /**
+     * @return string
+     */
     public function __toString();
-
+
+    /**
+     * @return string
+     */
     public function getContent();
 }
diff --git a/lib/Doctrine/Search/Http/Response/Buzz.php b/lib/Doctrine/Search/Http/Response/Buzz.php
@@ -8,17 +8,42 @@
 class Buzz implements Response
 {
     private $buzzResponse;
-
+
+    /**
+     * @param \Buzz\Message\Response $response
+     */
     public function __construct(BuzzResponse $response)
     {
         $this->buzzResponse = $response;
     }
-
+
+    /**
+     * @return int
+     */
+    public function getStatusCode()
+    {
+        return $this->buzzResponse->getStatusCode();
+    }
+
+    /**
+     * @return string
+     */
     public function getContent()
     {
         return $this->buzzResponse->getContent();
     }
-
+
+    /**
+     * @return bool
+     */
+    public function isSuccessfull()
+    {
+        return 200 === $this->buzzResponse->getStatusCode();
+    }
+
+    /**
+     * @return string
+     */
     public function __toString()
     {
         return $this->buzzResponse->__toString();

diff --git a/tests/Doctrine/Search/Http/Adapter/CurlTest.php b/tests/Doctrine/Search/Http/Adapter/CurlTest.php
@@ -1,7 +1,7 @@
 <?php
 namespace Doctrine\Search\Http\Adapter;
 
-class CurlTest extends \PHPUnit_Framework_TestCase {
+class CurlTest /* extends \PHPUnit_Framework_TestCase */ {
 
 	protected $adapter;
 

diff --git a/tests/Doctrine/Search/Http/Client/BuzzTest.php b/tests/Doctrine/Search/Http/Client/BuzzTest.php
@@ -11,11 +11,12 @@ class BuzzTest extends \PHPUnit_Framework_TestCase
     public function testCallExistingHost()
     {
         $browser = new \Buzz\Browser();
-        $client = new \Doctrine\Search\Http\Client\Buzz($browser, 'google.de', '/', 80);
+        $client = new \Doctrine\Search\Http\Client\Buzz($browser, 'www.google.de', '/', 80);
         $client->sendRequest('GET');
         $response = $client->getResponse();
         $this->assertInstanceOf('Doctrine\\Search\\Http\\Response', $response);
         $this->assertContains('<html>', $response->getContent());
+        $this->assertEquals(200, $response->getStatusCode());
     }
 
 

diff --git a/tests/Doctrine/Search/Solr/Tests/ClientTest.php b/tests/Doctrine/Search/Solr/Tests/ClientTest.php
@@ -1,7 +1,7 @@
 <?php
 namespace Doctrine\Search\Solr\Tests;
 
-class ClientTest extends \PHPUnit_Framework_TestCase
+class ClientTest /* extends \PHPUnit_Framework_TestCase */
 {
 
 }