Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hertzsentry feature #1

Merged
merged 16 commits into from
Oct 10, 2022
Merged

Conversation

gityh2021
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it (English/Chinese):

Which issue(s) this PR fixes:

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@li-jin-gou
Copy link
Contributor

li-jin-gou commented Sep 26, 2022

  • improve pr title / pr desc / readme + resolve ci
  • why not use go mod and add extra dir?

@gityh2021
Copy link
Collaborator Author

  • improve pr title / pr desc / readme + resolve ci
  • why not use go mod and add extra dir?

what does ci mean, I just know CICD.
I find that the dictionary of ginsentry and fibersentry did not contains go mod, so I didn't commit is.
add extra dir: I write a main file in main package, maybe didn't need it?

@gityh2021 gityh2021 changed the title hertzsentry init hertzsentry -> (This is a community driven project) Sep 28, 2022
@gityh2021 gityh2021 changed the title hertzsentry -> (This is a community driven project) [WIP] feat: add hertzsentry feature Sep 28, 2022
@li-jin-gou
Copy link
Contributor

li-jin-gou commented Sep 28, 2022

  • improve pr title / pr desc / readme + resolve ci
  • why not use go mod and add extra dir?

what does ci mean, I just know CICD. I find that the dictionary of ginsentry and fibersentry did not contains go mod, so I didn't commit is. add extra dir: I write a main file in main package, maybe didn't need it?

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
hertzsentry.go Outdated Show resolved Hide resolved
option.go Outdated Show resolved Hide resolved
option.go Show resolved Hide resolved
option.go Outdated Show resolved Hide resolved
2、add annotations on config functions.
2、add annotations on config functions.
option.go Outdated Show resolved Hide resolved
option.go Outdated Show resolved Hide resolved
hertz_sentry_test.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou changed the title [WIP] feat: add hertzsentry feature feat: add hertzsentry feature Oct 10, 2022
@li-jin-gou
Copy link
Contributor

LGTM

Copy link
Member

@Skyenought Skyenought left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants