feat(zap): add multiple zapcore support

[StellarisW]

What type of PR is this?

feat

What this PR does / why we need it (English/Chinese):

目前hlog的zap扩展不支持使用多个zapcore的场景，比如我既需要输出到控制台，又需要输出到日志文件

Which issue(s) this PR fixes:

[rogerogers]

logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
	return zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.ErrorLevel))
})))

maybe we could use zap.WrapCore custom our zapcore?

[StellarisW]

	logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
		return zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.ErrorLevel))
	})))

maybe we could use zap.WrapCore custom our zapcore?

WithZapOptions only affect struct config so the returned zapcore.Core is useless

[rogerogers]

l, err := os.OpenFile("log.log", os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0755)
if err != nil {
	log.Fatal(err)
}
logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
	return zapcore.NewTee([]zapcore.Core{
		zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(l), zap.NewAtomicLevelAt(zap.InfoLevel)),
		zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.InfoLevel)),
	}...)
})))

multiple zapcore by NewTee

[StellarisW]

l, err := os.OpenFile("log.log", os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0755)
if err != nil {
	log.Fatal(err)
}
logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
	return zapcore.NewTee([]zapcore.Core{
		zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(l), zap.NewAtomicLevelAt(zap.InfoLevel)),
		zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.InfoLevel)),
	}...)
})))

multiple zapcore by NewTee

it indeed a good way to use multiple zapcores in this way

[rogerogers]

l, err := os.OpenFile("log.log", os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0755)
if err != nil {
	log.Fatal(err)
}
logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
	return zapcore.NewTee([]zapcore.Core{
		zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(l), zap.NewAtomicLevelAt(zap.InfoLevel)),
		zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.InfoLevel)),
	}...)
})))

multiple zapcore by NewTee

it indeed a good way to use multiple zapcores in this way

We can mention this in our documentation, the code change is not necessary for this repository

[rogerogers]

logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
    return zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.ErrorLevel))
})))

maybe we could use zap.WrapCore custom our zapcore?

WithZapOptions only affect struct config so the returned zapcore.Core is useless

WrapCore will take effect finally, and will cause setOutput and setLevel not to work

[StellarisW]

logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
    return zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.ErrorLevel))
})))

maybe we could use zap.WrapCore custom our zapcore?

WithZapOptions only affect struct config so the returned zapcore.Core is useless

WrapCore will take effect finally, and will cause setOutput and setLevel not to work

In this case, to solve the warped zapcore.Core probles, we still need change methods SetLevel and SetOutput by NewTee and it will just change the first zapcore.Core in the warped zapcore.Core

[rogerogers]

logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
    return zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.ErrorLevel))
})))

maybe we could use zap.WrapCore custom our zapcore?

WithZapOptions only affect struct config so the returned zapcore.Core is useless

WrapCore will take effect finally, and will cause setOutput and setLevel not to work

In this case, to solve the warped zapcore.Core probles, we still need change methods SetLevel and SetOutput by NewTee and it will just change the first zapcore.Core in the warped zapcore.Core

It will look weird, and it's not so easy to change the wrapCore behavior, maybe we should avoid using these two func when using wrapCore

[StellarisW]

logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
    return zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.ErrorLevel))
})))

maybe we could use zap.WrapCore custom our zapcore?

WithZapOptions only affect struct config so the returned zapcore.Core is useless

WrapCore will take effect finally, and will cause setOutput and setLevel not to work

In this case, to solve the warped zapcore.Core probles, we still need change methods SetLevel and SetOutput by NewTee and it will just change the first zapcore.Core in the warped zapcore.Core

It will look weird, and it's not so easy to change the wrapCore behavior, maybe we should avoid using these two func when using wrapCore

... how's weeird?

[rogerogers]

logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
    return zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.ErrorLevel))
})))

maybe we could use zap.WrapCore custom our zapcore?

WithZapOptions only affect struct config so the returned zapcore.Core is useless

WrapCore will take effect finally, and will cause setOutput and setLevel not to work

In this case, to solve the warped zapcore.Core probles, we still need change methods SetLevel and SetOutput by NewTee and it will just change the first zapcore.Core in the warped zapcore.Core

It will look weird, and it's not so easy to change the wrapCore behavior, maybe we should avoid using these two func when using wrapCore

... how's weeird?

Why just change the first...

[StellarisW]

logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
    return zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.ErrorLevel))
})))

maybe we could use zap.WrapCore custom our zapcore?

WithZapOptions only affect struct config so the returned zapcore.Core is useless

WrapCore will take effect finally, and will cause setOutput and setLevel not to work

In this case, to solve the warped zapcore.Core probles, we still need change methods SetLevel and SetOutput by NewTee and it will just change the first zapcore.Core in the warped zapcore.Core

It will look weird, and it's not so easy to change the wrapCore behavior, maybe we should avoid using these two func when using wrapCore

... how's weeird?

Why just change the first...

As It can't specify the certain zapcore.Core, we have to to implement Control interface (just point this case in docs is ok)

[rogerogers]

logger := hertzzap.NewLogger(hertzzap.WithZapOptions(zap.WrapCore(func(core zapcore.Core) zapcore.Core {
    return zapcore.NewCore(zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig()), zapcore.AddSync(os.Stdout), zap.NewAtomicLevelAt(zap.ErrorLevel))
})))

maybe we could use zap.WrapCore custom our zapcore?

WithZapOptions only affect struct config so the returned zapcore.Core is useless

WrapCore will take effect finally, and will cause setOutput and setLevel not to work

In this case, to solve the warped zapcore.Core probles, we still need change methods SetLevel and SetOutput by NewTee and it will just change the first zapcore.Core in the warped zapcore.Core

It will look weird, and it's not so easy to change the wrapCore behavior, maybe we should avoid using these two func when using wrapCore

... how's weeird?

Why just change the first...

As It can't specify the certain zapcore.Core, we have to to implement Control interface (just point this case in docs is ok)

sounds ok

[rogerogers]

Do you join our lark community group or wechat group. contact me.

[StellarisW]

Do you join our lark community group or wechat group. contact me.

你飞书名字是啥

[rogerogers]

Do you join our lark community group or wechat group. contact me.

你飞书名字是啥

rogerogers

[rogerogers]

LGTM