Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slog): add slog implementation for hlog #36

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

rogerogers
Copy link
Collaborator

What type of PR is this?

feat(slog): add slog implementation for hlog

What this PR does / why we need it (English/Chinese):

zh: en: 增加hlog的slog实现

Which issue(s) this PR fixes:

@rogerogers
Copy link
Collaborator Author

这个怎么感觉只有1.21.0以后才能跑起来。 🤣

@ringsaturn
Copy link

这个怎么感觉只有1.21.0以后才能跑起来。 🤣

是的,只有 1.21.0 以后才有 log/slog 这个 package

https://pkg.go.dev/log/slog

@li-jin-gou
Copy link
Contributor

这个怎么感觉只有1.21.0以后才能跑起来。 🤣

针对 slog 的 ci 可以调整一下,看看能不能

@rogerogers rogerogers force-pushed the feat/slog branch 5 times, most recently from a730d8a to ce5d8e0 Compare September 19, 2023 14:08
Signed-off-by: rogerogers <rogers@rogerogers.com>
@li-jin-gou li-jin-gou marked this pull request as ready for review September 20, 2023 06:09
@rogerogers rogerogers changed the title WIP: feat(slog): add slog implementation for hlog feat(slog): add slog implementation for hlog Sep 20, 2023
li-jin-gou and others added 3 commits September 20, 2023 14:30
Signed-off-by: rogrogers <rogers@rogerogers.com>
Signed-off-by: rogrogers <rogers@rogerogers.com>
@li-jin-gou li-jin-gou merged commit 1ca477f into hertz-contrib:main Sep 20, 2023
9 checks passed
@rogerogers rogerogers deleted the feat/slog branch November 9, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants