Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default bucket sizes #1

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

rogerogers
Copy link
Collaborator

@rogerogers rogerogers commented Sep 3, 2022

What type of PR is this?

What this PR does / why we need it (English/Chinese):

en: Change histogram bucket size, the current bucket size is too small and meaningless. Add some test.
zh: 修改histogram bucket大小,现在的值太小了几乎无意义。添加了一点测试。

Which issue(s) this PR fixes:

@rogerogers rogerogers changed the title chore: increase bucket sizes chore: change default bucket sizes Sep 3, 2022
@rogerogers
Copy link
Collaborator Author

@lin1318 @Duslia 大佬们有时间了帮忙review下。

@rogerogers rogerogers force-pushed the fix/bucket branch 3 times, most recently from faecb6b to 7dffe99 Compare September 3, 2022 09:11
@Duslia
Copy link
Collaborator

Duslia commented Sep 4, 2022

这样写测试话 ci 好像过不去吧?

@rogerogers
Copy link
Collaborator Author

这样写测试话 ci 好像过不去吧?

哪个step,test吗

@Duslia Duslia merged commit 058836e into hertz-contrib:main Sep 5, 2022
@Duslia Duslia changed the title chore: change default bucket sizes feat: change default bucket sizes Sep 5, 2022
@rogerogers rogerogers deleted the fix/bucket branch September 12, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants