feat(logging): support non recording span (#9)

hertz-contrib · Sep 20, 2022 · afc948b · afc948b
1 parent 598d159
commit afc948b
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/logging/logrus/hook.go b/logging/logrus/hook.go
@@ -62,15 +62,17 @@ func (h *TraceHook) Fire(entry *logrus.Entry) error {
 	}
 
 	span := trace.SpanFromContext(entry.Context)
-	if !span.IsRecording() {
-		return nil
-	}
 
 	// attach span context to log entry data fields
 	entry.Data[traceIDKey] = span.SpanContext().TraceID()
 	entry.Data[spanIDKey] = span.SpanContext().SpanID()
 	entry.Data[traceFlagsKey] = span.SpanContext().TraceFlags()
 
+	// non recording spans do not support modifying
+	if !span.IsRecording() {
+		return nil
+	}
+
 	// attach log to span event attributes
 	attrs := []attribute.KeyValue{
 		logMessageKey.String(entry.Message),