Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zap log #8

Merged
merged 4 commits into from
Sep 27, 2022
Merged

feat: add zap log #8

merged 4 commits into from
Sep 27, 2022

Conversation

rogerogers
Copy link
Collaborator

Signed-off-by: rogerogers rogers@rogerogers.com

What type of PR is this?

feat: add zap log

What this PR does / why we need it (English/Chinese):

en: add zap log
zh: 增加zap适配

Which issue(s) this PR fixes:

Signed-off-by: rogerogers <rogers@rogerogers.com>
logging/zap/logger.go Outdated Show resolved Hide resolved
rogerogers and others added 2 commits September 20, 2022 22:22
Signed-off-by: rogerogers <rogers@rogerogers.com>
@rogerogers rogerogers requested review from CoderPoet and removed request for li-jin-gou September 20, 2022 14:34
Signed-off-by: rogerogers <rogers@rogerogers.com>
Copy link
Collaborator

@CoderPoet CoderPoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@li-jin-gou li-jin-gou merged commit 96de10b into hertz-contrib:main Sep 27, 2022
@rogerogers rogerogers deleted the feature/zap branch September 27, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants