Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more example #37

Merged
merged 3 commits into from
Apr 23, 2023
Merged

feat: add more example #37

merged 3 commits into from
Apr 23, 2023

Conversation

a631807682
Copy link
Member

What type of PR is this?

What this PR does / why we need it (English/Chinese):

en: Add a more example for servicecomb
zh: 增加servicecomb示例

Which issue(s) this PR fixes:

cloudwego/hertz#485

@li-jin-gou li-jin-gou added the enhancement New feature or request label Feb 22, 2023
@welkeyever
Copy link

Covered by #79 ?

@a631807682
Copy link
Member Author

Covered by #79 ?

Doesn't seem to be related to #79, #79 proposes using sonic optimizations, but servicecomb itself doesn't require serialization, only used in the example.
Of course we can also use sonic in the example, but in general they don't have much relationship.

@li-jin-gou
Copy link
Collaborator

need to cr

@li-jin-gou
Copy link
Collaborator

PATl @justlorain @L2ncE

welkeyever
welkeyever approved these changes Mar 8, 2023
View reviewed changes
Copy link

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

justlorain
justlorain approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@justlorain justlorain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@li-jin-gou li-jin-gou merged commit ccd7972 into hertz-contrib:main Apr 23, 2023
@a631807682 a631807682 deleted the feat_servicecomb_example branch April 23, 2023 04:16
@a631807682 a631807682 mentioned this pull request Jul 17, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welkeyever welkeyever welkeyever approved these changes

@justlorain justlorain justlorain approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@a631807682 @welkeyever @li-jin-gou @justlorain