fix(nacos): client.WithTag does not work #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
polaris 的 docker 源出问题了, 谁修复一下 |
L2ncE
reviewed
Jun 16, 2023
CI has been fixed, you can have a rebase. |
Skyenought
force-pushed
the
tagsdas
branch
4 times, most recently
from
9c19536
to
9ae2437
Compare
li-jin-gou
approved these changes
Jun 19, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
What this PR does / why we need it (English/Chinese):
zh: 修复了 withtag 在 nacos client 侧无效的问题
由于实现 target 方法过于简单, 直接忽略了 tags 的处理, 导致失效
Which issue(s) this PR fixes:
cloudwego/hertz#596